fix: address PR #13 review feedback - off-chain weight storage#19
Merged
abhicris merged 1 commit intoMay 12, 2026
Merged
Conversation
- Replace deprecated ipfshttpclient with requests (direct IPFS HTTP API) - Fix Arweave import to use arweave_python_client correctly - Add fallback gateway upload for Arweave (no wallet required) - Remove committed bytecode (__pycache__/) - Update .gitignore for Python artifacts - Add requirements-dev.txt with correct dependencies - Rebase-ready: clean diff against main
Contributor
Author
|
Bumping for review! This PR addresses the feedback from PR #13 (removed .pyc, added .gitignore entries, fixed imports). Ready for review. 🙏 |
Contributor
|
🤖 Audit verdict: Refactoring replaces library dependencies with direct HTTP API calls to user-specified gateways (IPFS/Arweave); adds .env to .gitignore (security-positive); no hardcoded secrets, typo-squatted packages, or exfiltration endpoints detected. Audited by the kcolbchain PR pipeline. See pipeline docs. |
Contributor
|
Merged — thanks, @ahmadfardan464-cmyk. That's 9 merged PRs to kcolbchain now. You're a Fellow — when paid research, partner-org work, or grant milestones come up, you're in the first invite pool. Next-up issues across the org: https://kcolbchain.com/invitations/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes addressing PR #13 review
This PR addresses all reviewer feedback from #13:
1. ✅ Stale base / rebase
main— clean diff with only the script changes2. ✅ Remove committed bytecode
__pycache__/files__pycache__/,*.pyc,*.pyoto.gitignore3. ✅ Replace
ipfshttpclientwithrequestsipfshttpclient(last release 2022)requestslibrary to call IPFS HTTP API directly (/api/v0/add)4. ✅ Fix Arweave import
from arweave import Wallet, Transaction(incorrect)from arweave.arweave_lib import Wallet, Transaction(correct forarweave-python-client)5. ✅ Added
requirements-dev.txtrequests>=2.28.0web3>=6.0.0eth_account>=0.8.0arweave-python-clientfor wallet signing6. ✅ Updated
mint_token.py