feat: add ERC777ReentrancyCheck for tokensReceived reentrancy#25
Open
invisiblemonsters wants to merge 1 commit into
Open
feat: add ERC777ReentrancyCheck for tokensReceived reentrancy#25invisiblemonsters wants to merge 1 commit into
invisiblemonsters wants to merge 1 commit into
Conversation
- src/checks/ERC777ReentrancyCheck.sol: abstract check detecting ERC-777 reentrancy - test/ERC777Reentrancy.t.sol: test suite with VulnerableERC777Vault fixture - README.md: add ERC777ReentrancyCheck to checks table and architecture Closes kcolbchain#19
Contributor
|
Welcome to kcolbchain, @invisiblemonsters — glad you're here. 🌱 Here's what happens from this PR:
While you wait:
What happens after your first merge
Thanks for writing the code. We're building this to last. |
Contributor
|
🤖 Audit verdict: Legitimate audit check library for detecting ERC-777 reentrancy vulnerabilities (imBTC/Uniswap V1 class); intentional vulnerable and fixed test contracts for demonstration; no malicious code, credentials, or logic errors detected. Audited by the kcolbchain PR pipeline. See pipeline docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19 — Add ERC-777 reentrancy detection to the audit checklist.
Changes
tokensReceivedreentrancy by deploying a mock ERC-777 token and an attacker that re-enters from the callback hookVulnerableERC777Vaultfixture (withdraws before balance update — classic 2020 imBTC/Uniswap V1 bug) and aFixedAuditvariant proving the check passes when reentrancy is mitigatedERC777ReentrancyCheckto checks table and architecture diagramAcceptance Criteria
withdrawFixedvariant)References