Fix Discord cron routing fallback - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
payload.discordThreadIdor the explicitchannels.discord.defaultChannelId.Unknown Channelresponses from network, authentication, and other fetch failures.Why
The live cron route fields were removed after channel lookup failures were treated as stale targets. With Discord active, untargeted cron notifications then fell through to the active-channel sender, which resolved
allowFromas a user and delivered every job by DM.This keeps per-job channel routing explicit and prevents configuration loss or a transient Discord failure from turning into an unexpected DM flood.
Testing
pnpm buildpnpm test— 81 files, 983 tests passedpnpm lintManual testing
payload.discordThreadId; confirm start and completion messages appear in that channel/thread and not in DM.channels.discord.defaultChannelId; confirm it posts there and does not use the DM path.10003versus a network fetch failure; confirm only10003is reported as a missing channel.