[DK][SSAV2] pass the selected_parent into remove_bounded_merge_breaking_parents - #1122
Open
D-Stacks wants to merge 4 commits into
Conversation
coderofstuff
reviewed
Sep 6, 2026
|
|
||
| fn remove_bounded_merge_breaking_parents( | ||
| &self, | ||
| selected_parent: Hash, |
Collaborator
There was a problem hiding this comment.
Since the signature of this function is changing, what do you think about simply creating pick_virtual_parents_v2 and remove_bounded_merge_breaking_parents so we can more-freely change the behavior here without worrying about backward compatibility with what GD needs/expects?
Collaborator
Author
There was a problem hiding this comment.
Yes, I think this is worth-while for separation of concerns regarding pre- and post dk handling. I created a separate PR for it, here:
it also changes some handling of the testnet wiring.
After that is merged I will update my other PRs to it.
D-Stacks
marked this pull request as draft
September 7, 2026 11:12
Collaborator
Author
|
converted to draft pending #1123 |
…ed_parent_into_remove_bounded_breaking_parents_call
D-Stacks
marked this pull request as ready for review
September 19, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes the
selected_parentexplicitly intoremove_bounded_merge_breaking_parents, Since we know the SP beforehand this avoids unnecessary re-runs of dagknight inremove_bounded_merge_breaking_parentsto re-establish the SP.