Conversation
KeenHero
marked this pull request as ready for review
August 14, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Kaspa's actual 118 byte serialized P2PK input size in wallet dust calculations.
Root cause
The wallet inherited Bitcoin's combined 148 byte output and input estimate, then added the Kaspa output size again. This overestimated the cost of spending a P2PK output and raised the dust threshold.
Impact
Wallet dust checks now use the 36 byte outpoint, 8 byte signature length, 66 byte signature script, and 8 byte sequence. A boundary regression test covers the resulting threshold.
Fixes #750.
Validation
cargo test -p kaspa-wallet-core p2pk_dust_threshold_uses_actual_input_size