Skip to content

fix(router): use instanceof Router instead of constructor.name for sub-router detection #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartikk221 merged 1 commit into from
Jul 13, 2026
+1 −1
Merged

fix(router): use instanceof Router instead of constructor.name for sub-router detection #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/router/Router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ class Router {
} else if (Array.isArray(candidate)) {
// Scenario: Array of functions
candidate.forEach((middleware) => this._register_middleware(pattern, middleware));
} else if (typeof candidate == 'object' && candidate.constructor.name === 'Router') {
} else if (candidate instanceof Router) {
// Scenario: Router instance
this._register_router(pattern, candidate);
} else if (candidate && typeof candidate == 'object' && typeof candidate.middleware == 'function') {
Expand Down