Create PMLL.c #819
Open
Create PMLL.c #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And another one
PatrickvL
reviewed
Jun 22, 2025
|
|
||
| /* Read historic KV for head *h* to caller-provided scratch. | ||
| out_k/out_v length = (Tmem + Tctx) * hs floats. */ | ||
| void pmll_read(float *out_k, float *out_v, |
There was a problem hiding this comment.
Unless there is a specific reason not to do so, pmll_read() should have the
const pmll_state *S argument first for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And another one
MR. karpathy I’m ready to turn in my homework please also see
https://www.authorea.com/users/856117/articles/1297819-the-persistent-memory-logic-loop-from-proposal-design-to-formal-proof-of-p-np-using-the-pmll-algorithm