Validate smart macro event names#129
Open
kareltucek wants to merge 1 commit intomasterfrom
Open
Conversation
Owner
kareltucek
commented
May 5, 2026
- Add K-boot flashing analysis documentation
- Add firmware upload proposal with current config flow
- Add missing secondary role settings to user config (version 14)
- ParseConfig: use explicit serialization enums for secondary roles.
- Kboot: Add an overview implementation plan.
- reword.
- Implement new usb flashing Api.
- Kboot: Enable kboot driver on Zephyr and add shell command.
- Implement a poc of kboot-module communication.
- nrf: update sysbuild presets workaround with upstream
- move c2usb interfacing code under the right sources
- split vscode to two workspaces, one for nrfsdk and one for mcuxsdk development
- right: integrate c2usb into the build, without any effect
- tooling configuration update
- major refactoring of UHK60 right USB interface
- Fix PID in west_agent.py
- Handle uhk60 debug builds in build.sh.
- Add vscode build variants.
- Log and reconnect on repeated report send fails.
- Check hogp health. Disconnect if it doesn't look good.
- release with debug info
- scripts: add west vscode command
- Fix healthcheck compilation.
- Use system build environment in build.sh.
- DOCS: add uhk80 vscode debugging stuff.
- agent doesn't support report ID on UHK60
- uhk60: make debugging possible with bootloader+app flashing
- c2usb fixes
- ci: use latest zephyr SDK
- uhk60: restore suspend and resume handling
- assume high resolution scrolling when enumerated on Windows
- uhk60: fix buspal USB
- set manifest path at workspace loading
- c2usb integration update
- Revert c2usb input interceptor removal -> fix pairing screen.
- Fix serial number length. And consequent memory corruption.
- Implement proper retry handling on dongle.
- Revert "Implement proper retry handling on dongle."
- Block/retry for dongle usb transports.
- Fix shell log filtering.
- Remove some aggressive reconnection attempts.
- fix debugging with west vscode generated config
- c2usb zephyr USB handling update
- don't advertise NUS by name, as it's not used at scanning
- Hid transport: Adjust error logging.
- Update dongle scroll multipliers.
- fixup! c2usb zephyr USB handling update
- fix hogp report sending getting stuck in busy error
- Fix input processing during usb resend periods.
- Unselect host on second tap.
- Update changelog and bump versions.
- Send battery level notifications only if the host is awake.
- Add regression test.
- Fix the Layers/layer_hold_replace_layer regression.
- Fix some warnings.
- Instrument BLE HID report dispatch→sent latency.
- Throttle report construction on slow transports.
- Wire the report throttle to actual ble hid interval
- Throttling: make it work for dongle too.
- Throttling: refactor testing code away.
- Remove surplus comment.
- Implement kboot write.
- Some comments.
- DOCS: add a link to the agent smart macro pane.
- DOCS: readme doc updates.
- ci: bump JamesIves/github-pages-deploy-action 4.0.0 => 4.8.0
- ci: bump JamesIves/github-pages-deploy-action 4.0.0 => 4.8.0 (ci: bump JamesIves/github-pages-deploy-action 4.0.0 => 4.8.0 UltimateHackingKeyboard/firmware#1530)
- ci: bump actions to the latest major
- ci: bump actions to the latest major (ci: bump actions to the latest major UltimateHackingKeyboard/firmware#1531)
- Add exact send report traces.
- Add tests for macro sticky keys.
- Fix premature reset of macro sticky mods.
- Disable thread performance stats.
- Prevent github ci from building from "nonexistent" commit hashes.
- Fix errors.
- Update CHANGELOG and bump versions.
- Bump Agent reference.
- ci: use github.ref instead of github.sha to use git tag when releasing new version (ci: use github.ref instead of github.sha to use git tag when releasing new version UltimateHackingKeyboard/firmware#1535)
- ci: add missing v to the JamesIves/github-pages-deploy-action version (ci: add missing v to the JamesIves/github-pages-deploy-action version UltimateHackingKeyboard/firmware#1537)
- Validate smart macro event names
Macro names that begin with `$` are treated as event handlers (e.g. `$onInit`, `$onKeymapChange`, `$onLayerChange`). Until now, unknown event names like `$onKeyMapChange` (camel-case typo) were silently ignored, leaving the user with a non-functional handler and no diagnostic. Walk all macros after Macros_ValidateAllMacros and emit a status buffer error for any `$`-prefixed name that doesn't match a known event, has the wrong number of arguments, or specifies a layer name that Macros_ConsumeLayerId rejects. Refs UltimateHackingKeyboard#1536
bc6d28c to
224ad19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.