Fix the recording caret algorithm might calculate wrong position if time-tag is not order in the lyric.#1166
Draft
andy840119 wants to merge 4 commits intokaraoke-dev:masterfrom
Draft
Conversation
Member
Author
|
確認一下:
或許比較好的方式是在新增 time-tag 時還是讓 list 插入在正確位置? |
andy840119
force-pushed
the
fix-the-recording-caret-algorithm
branch
from
c1a58c5 to
0980de5
Compare
andy840119
force-pushed
the
fix-the-recording-caret-algorithm
branch
from
9020964 to
344eb05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix the case that time-tag might not always be by order in the list, which will cause the caret algorithm to get the wrong position.