This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Make log height dynamic#1771
Merged
kahboom merged 1 commit intokaoto-archive:mainfrom May 10, 2023
Merged
Conversation
lordrip
approved these changes
May 9, 2023
Collaborator
lordrip
left a comment
lordrip
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1771 +/- ##
==========================================
- Coverage 66.35% 66.05% -0.31%
==========================================
Files 74 75 +1
Lines 2158 2180 +22
Branches 482 485 +3
==========================================
+ Hits 1432 1440 +8
- Misses 682 695 +13
- Partials 44 45 +1
|
kahboom
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires patternfly/react-log-viewer#28 to work
Closes 577