Skip to content

Conversation

@mehmetcangulesci
Copy link
Contributor

@mehmetcangulesci mehmetcangulesci commented Sep 7, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Implemented the feature request #1318
Fixes #1318

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@mehmetcangulesci mehmetcangulesci requested review from a team as code owners September 7, 2025 08:29
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 7, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi mehmetcangulesci! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@mehmetcangulesci mehmetcangulesci force-pushed the feature/connector-failed-modal branch from 3a324b3 to 5425423 Compare September 24, 2025 09:22
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 5, 2025
Copy link
Contributor

@Leshe4ka Leshe4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mehmetcangulesci !
Thank you for contributing! I have add few comments, please, check it out

@mehmetcangulesci mehmetcangulesci force-pushed the feature/connector-failed-modal branch from a461b3e to 5e18797 Compare October 28, 2025 07:58
@mehmetcangulesci
Copy link
Contributor Author

Hi, @mehmetcangulesci ! Thank you for contributing! I have add few comments, please, check it out

Hi @Leshe4ka Thank you for the detailed review and great suggestions!

I've implemented all your feedback:

Reusable Modal Component: Created a reusable Modal component in components/common/Modal that can be used throughout the application
Helper Function: Refactored the conditional logic into a canShowTrace helper function with proper TypeScript typing
Clickable Prop: Added a clickable prop to the C.Tag component to replace inline styles
Conditional Rendering: Fixed the conditional rendering to avoid empty wrapper elements

@Haarolean Haarolean changed the title FE: Show connector-level trace when status is FAILED KC: Show connector-level trace when status is FAILED Nov 3, 2025
@Haarolean Haarolean added this to the 1.4 milestone Nov 3, 2025
@Haarolean
Copy link
Member

@mehmetcangulesci thank you for your contribution. For the future reference, please do not raise PRs before the issue has been triaged and OK'ed. This feature is nice, but it might happen that we might not want to accept everything proposed even with a submitted PRs.

@Haarolean
Copy link
Member

@mehmetcangulesci could you please address failing backend build? From a quick look, this might be related to the fact you've adjusted .tsp spec which is used for the frontend files generation, but the origin is OpenAPI reference (contract/src/main/resources/swagger/kafbat-ui-api.yaml).

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Nov 3, 2025
@Haarolean Haarolean added the area/connect Kafka Connect, its connectors label Nov 3, 2025
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.4 Nov 3, 2025
@mehmetcangulesci mehmetcangulesci force-pushed the feature/connector-failed-modal branch from 9f507f3 to 103c2db Compare November 3, 2025 17:18
@mehmetcangulesci
Copy link
Contributor Author

@mehmetcangulesci thank you for your contribution. For the future reference, please do not raise PRs before the issue has been triaged and OK'ed. This feature is nice, but it might happen that we might not want to accept everything proposed even with a submitted PRs.

@Haarolean Thanks for the feedback! Totally understood — I’ll make sure to wait for issue triage and approval before opening a PR next time. Appreciate the clarification and the review 🙏

@mehmetcangulesci
Copy link
Contributor Author

@mehmetcangulesci could you please address failing backend build? From a quick look, this might be related to the fact you've adjusted .tsp spec which is used for the frontend files generation, but the origin is OpenAPI reference (contract/src/main/resources/swagger/kafbat-ui-api.yaml).

@Haarolean Thanks for catching that! I’ve fixed the failing backend build in the latest commit.

@Haarolean
Copy link
Member

@mehmetcangulesci thanks. Please also refrain from force pushing next time, as it renders the diff as a new one which forces the reviewers to review the whole PR again.

@Haarolean Haarolean enabled auto-merge (squash) November 4, 2025 13:20
@Haarolean Haarolean merged commit 13f545b into kafbat:main Nov 4, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Nov 4, 2025
@mehmetcangulesci
Copy link
Contributor Author

@mehmetcangulesci thanks. Please also refrain from force pushing next time, as it renders the diff as a new one which forces the reviewers to review the whole PR again.

@Haarolean Thanks for the heads-up! Got it, I’ll avoid force pushing next time to keep the diff reviewable.

@Haarolean
Copy link
Member

@mehmetcangulesci thanks for your first contribution to kafbat ui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connect Kafka Connect, its connectors hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

KC: Show connector-level trace when status is FAILED

3 participants