-
-
Notifications
You must be signed in to change notification settings - Fork 203
KC: Show connector-level trace when status is FAILED #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KC: Show connector-level trace when status is FAILED #1319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi mehmetcangulesci! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
3a324b3 to
5425423
Compare
frontend/src/components/Connect/Details/Overview/Overview.styled.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mehmetcangulesci !
Thank you for contributing! I have add few comments, please, check it out
a461b3e to
5e18797
Compare
Hi @Leshe4ka Thank you for the detailed review and great suggestions! I've implemented all your feedback: ✅ Reusable Modal Component: Created a reusable |
|
@mehmetcangulesci thank you for your contribution. For the future reference, please do not raise PRs before the issue has been triaged and OK'ed. This feature is nice, but it might happen that we might not want to accept everything proposed even with a submitted PRs. |
|
@mehmetcangulesci could you please address failing backend build? From a quick look, this might be related to the fact you've adjusted |
… Modal component and update trace display logic
…ic for connector status
9f507f3 to
103c2db
Compare
@Haarolean Thanks for the feedback! Totally understood — I’ll make sure to wait for issue triage and approval before opening a PR next time. Appreciate the clarification and the review 🙏 |
@Haarolean Thanks for catching that! I’ve fixed the failing backend build in the latest commit. |
|
@mehmetcangulesci thanks. Please also refrain from force pushing next time, as it renders the diff as a new one which forces the reviewers to review the whole PR again. |
@Haarolean Thanks for the heads-up! Got it, I’ll avoid force pushing next time to keep the diff reviewable. |
|
@mehmetcangulesci thanks for your first contribution to kafbat ui! |
What changes did you make? (Give an overview)
Implemented the feature request #1318
Fixes #1318
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)