This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Open
Conversation
larskuhtz
force-pushed
the
evm/lars/fix-race-in-ea
branch
from
dc49fb1 to
1d9401b
Compare
Contributor
|
We used to have more payloads being generated in ea, and this saved us a lot of time. If the parser throws an error can you post it? |
edmundnoble
suggested changes
Oct 14, 2025
Contributor
edmundnoble
left a comment
edmundnoble
left a comment
There was a problem hiding this comment.
I'm not convinced that this is a good idea. I don't see any possibility for races here. If anything, I'd like ea to have more concurrency, not less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ea has a race condition in the Pact transaction parser. It is not completely clear to me what triggers it.One possibility would be the generation of headers that contain information for more than one version.
Making Ea process chainweb versions sequentially probably fixes it.