This repository was archived by the owner on Nov 24, 2025. It is now read-only.
check defpacts for completion in preinsert check#2202
Draft
edmundnoble wants to merge 2 commits intopp/evmfrom
Draft
check defpacts for completion in preinsert check#2202edmundnoble wants to merge 2 commits intopp/evmfrom
edmundnoble wants to merge 2 commits intopp/evmfrom
Conversation
Change-Id: Id0000000c60d845aa153e43572634523b216e77a
Change-Id: Id00000006fd84f56c27dcd113bb387c19f70ff18
edmundnoble
force-pushed
the
push-tkmrvkutnxsm
branch
from
17a074e to
965ae4b
Compare
rsoeldner
reviewed
Oct 6, 2025
| | InsertErrorTimedOut | ||
| | InsertErrorPactParseError Text | ||
| | InsertErrorWrongChain Text Text | ||
| | InsertErrorDefPactComplete Text |
Member
There was a problem hiding this comment.
Any reason against using DefPactId and render the error later?
Contributor
There was a problem hiding this comment.
I tend to agree that I prefer richer types in error data types, with a render function. But, this is only a weak concern from me.
Contributor
|
I recommend adding a test once the SPV endpoints are working on pp/evm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should also ensure that we don't do any duplicate reads during the check. Needs a test.