This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Allow pow to be disabled by default in chainweb versions#2160
Open
edmundnoble wants to merge 1 commit intomasterfrom
Open
Allow pow to be disabled by default in chainweb versions#2160edmundnoble wants to merge 1 commit intomasterfrom
edmundnoble wants to merge 1 commit intomasterfrom
Conversation
Change-Id: Id0000000e1649a5b99329990bf39c9395e7cac69
larskuhtz
approved these changes
May 7, 2025
Contributor
larskuhtz
left a comment
larskuhtz
left a comment
There was a problem hiding this comment.
Approved with one more general question about the command line parser for ChainwebVersion.
| <*> optional (textOption @Fork (long "fork-upper-bound" <> help "(development mode only) the latest fork the node will enable")) | ||
| <*> optional (BlockDelay <$> textOption (long "block-delay" <> help "(development mode only) the block delay in seconds per block")) | ||
| <*> switch (long "disable-pow" <> help "(development mode only) disable proof of work check") | ||
| <*> optional (switch (long "disable-pow" <> help "(development mode only) disable proof of work check")) |
Contributor
There was a problem hiding this comment.
Is there a reason why parseVersion is not following the idiom for command lines parers from configuration-tools that is used everywhere else in Chainweb node? That idiom would prevent bugs like this one.
I guess, and configuration of ChainwebVersion is special and doesn't fit that pattern? Or is it just an oversight?
Contributor
Author
There was a problem hiding this comment.
Yes the weirdness here is that we parse the chainweb version, and then we parse a bunch of options that also alter this chainweb version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Id0000000e1649a5b99329990bf39c9395e7cac69