Conversation
| go doc <gophercloud-module>.<Type> | ||
| go doc <gophercloud-module>.CreateOpts | ||
| ``` | ||
| - Note field types precisely: `int32` in gophercloud → `*int32` in status (not `*int`) |
There was a problem hiding this comment.
Always? Maybe I'm splitting hairs here, but a scenario where I don't believe we should have it as a pointer is when the zero-value doesn't matter. For instance, the new AddressScope controller has an IPVersion field returned by the API, and it should always be returned because we must specify it at creation and it can't be null. Here, the zero value does not matter since the possible values are only two: 4 or 6. Does it make sense?
| @@ -198,24 +212,38 @@ Implement: | |||
| - `CreateResource()` - Build CreateOpts, call OpenStack API | |||
| - `DeleteResource()` - Call delete API | |||
| - `ListOSResourcesForImport()` - Apply filter to list results | |||
There was a problem hiding this comment.
Here, we also want to add all available fields for filtering. Wdyt?
| **This step is required** - do not skip it. | ||
|
|
||
| Complete the test stubs in `internal/controllers/<kind>/tests/` and run tests following @.agents/skills/testing/SKILL.md | ||
| The scaffolding tool creates test directory stubs in `internal/controllers/<kind>/tests/` with README files explaining each test suite's purpose. |
There was a problem hiding this comment.
I believe it'd be good to include an orientation on implementing all kinds of tests that we provide. That is, e2e tests, unit tests via actuator_test.go for mutable fields and via apivalidation package for API validations.
Regarding the latter, @mandre pushed a PR making changes to the apivalidation package. If you all agree, it'd also be good to add them here as well.
|
Hi @winiciusallan thanks for the very quick review, this should have been a draft but for some reason I am unable to convert it, I'll take a look at the comments but would mention this is still work in progress |
Oh, that's ok. Sorry if I reviewed it too soon. |
|
NP thanks for the review :) |
2 participants
improve skills