Starting fish sub-shells with activated environment#255
Draft
icezyclon wants to merge 1 commit intojustinmayer:mainfrom
Draft
Starting fish sub-shells with activated environment#255icezyclon wants to merge 1 commit intojustinmayer:mainfrom
icezyclon wants to merge 1 commit intojustinmayer:mainfrom
Conversation
…f virtual.fish if required (contains debug output)
Author
|
I just realized, we could also not use fish_user_paths at all, keeping the normal PATH, but still move the _VF_EXTRA_PATH to the front (because fish_add_paths did not end up working as expected anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR regarding #254
Added the following changes:
fish_user_pathsandPATH(_VF_EXTRA_PATH may be part of only PATH if we are in a sub-shell because fish_user_paths is restored at fish startup) and delete _VF_EXTRA_PATHvirtual.fishload: if we are in a virtual environment, set by virtualfish AND _VF_EXTRA_PATH does not appear in fish_user_paths, then we just loaded into a sub-shell and must re-order _VF_EXTRA_PATH to the front of fish_user_paths (and out of regular PATH)Use cases I have tried:
I added a lot of debug output to make it easy to test, for actually merging this would of course be removed!