Bump MAX_BPI to 128, to make jazz players happy#8
Open
brunorc wants to merge 2 commits intojustinfrankel:mainfrom
Open
Bump MAX_BPI to 128, to make jazz players happy#8brunorc wants to merge 2 commits intojustinfrankel:mainfrom
brunorc wants to merge 2 commits intojustinfrankel:mainfrom
Conversation
Many jazz standards are 32 bars long. While it's possible to change this settings from the Ninjam console, it would be nice to be able to get this value from the config file (and block the console changes).
Set MAX_BPI to 128, to allow 32 bars long loops
|
Hi. I join this request too. Is it possible to make sure to bring the MAX BPI to 128 or even more and possibly lower the MIN BPM to 20? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was in the proces of creating some predefined Ninjam sessions and testing the outcome. I was surprised to see that even though I've set
DefaultBPIto 128, the loop was still 16 bars long. I wanted to have two sessions tweaked for jazz standards, which are in most cases 32 bars long, and while I can still do/bpi 128and it will work, I thought it would be nicer to do it from the config file.