Fix link generator to use targetPath in urlpath construction#386
Open
ntaback wants to merge 1 commit intojupyterhub:mainfrom
Open
Fix link generator to use targetPath in urlpath construction#386ntaback wants to merge 1 commit intojupyterhub:mainfrom
ntaback wants to merge 1 commit intojupyterhub:mainfrom
Conversation
When a custom targetPath is specified, the link generator was not using it when constructing the urlpath parameter. This fix ensures that targetPath is used as the clone directory in the generated URL path, falling back to the repo-derived name only when targetPath is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetPathis specified in the link generator, theurlpathparameter was incorrectly using the repo-derived directory name instead of the specifiedtargetPathgetEffectiveCloneDirectory()helper function that returnstargetPathwhen provided, falling back to the default name when emptydisplayLink()to use this helper for both regular repos and binder auth tab scenariosTest plan
targetPathwhen specifiedtargetPathis empty