Fix websocket requests not mapped via mappath #526
Conversation
This is done by instead of WebSocketHandlerMixin providing the default `get` method and delegating to `ProxyHandler.http_get`, it now provides `get_websocket` and `ProxyHandler.proxy` delegates to it. Code is also removed that was never reached since it checked for the "Upgrade" HTTP header after removing it among others defined in `hop_by_hop_headers`. Fixes jupyterhub#525
for more information, see https://pre-commit.ci
|
|
Previously, `proxy` was changed to be used also for websockets and rawsockets so that mappath was also applied. This commit fixes the rawsocket `proxy` method erroring by default, which led to errors in the CI tests together with the previous change.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Fixed the rawsocket handler. Its The belief I wrote in the above comment therefore was wrong, the CI failed due to an actual issue. I also added a test for websocket+mappath, testing for the behavior introduced by this PR. |
|
@manics Quick question: I am actively waiting for this since how I implemented another project depends on this at the moment. What is the status here? If there is another way to map paths to websockets, that would be interesting of course as well. |
1 participant
This is done by instead of WebSocketHandlerMixin providing the default
getmethod and delegating toProxyHandler.http_get, it now providesget_websocketandProxyHandler.proxydelegates to it.Code is also removed that was never reached since it checked for the "Upgrade" HTTP header after removing it among others defined in
hop_by_hop_headers.Fixes #525