-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Clarify test descriptor implementation requirements #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mpkorstanje
merged 7 commits into
main
from
fix/document-test-type-consistency-requirements
Dec 1, 2025
Merged
Clarify test descriptor implementation requirements #5170
mpkorstanje
merged 7 commits into
main
from
fix/document-test-type-consistency-requirements
Dec 1, 2025
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft for the purpose of team discussion. Open questions:
|
7bce0ed to
65eefdd
Compare
* Define test and container as non-exclusive properties. * Use emphasis to distinguish between term and word. * Document that TestDescriptor.Type values are exclusive properties. * Document that `getChildren()`, `getDescendants()` and `mayRegisterTests()` must be consistent with `isContainer()`.
e4a181c to
492cbb5
Compare
Contributor
Author
|
Resolution after team discussion:
|
marcphilipp
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestDescriptor.Typevalues are exclusive properties.isContainer()andisTest()must be consistent withgetType().getChildren(),getDescendants()andmayRegisterTests()must be consistent withisContainer().Fixes: #5168
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations