Introduce `commentCharacter` attribute in `@Csv{File}Source` #5031

vdmitrienko · 2025-10-06T21:38:45Z

I hereby agree to the terms of the JUnit Contributor License Agreement.

#5028

Definition of Done

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in the User Guide and Release Notes

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvReaderFactory.java

vdmitrienko · 2025-10-11T11:31:08Z

@vdmitrienko, is this PR "ready for review"?

@sbrannen, I’d like to update the User Guide and Release Notes, but other than that, it’s ready.

UPD

The User Guide and Release Notes updated ✔️

vdmitrienko · 2025-10-11T14:46:44Z

@marcphilipp, @sbrannen, I'm a bit confused 😅 . According to the compatibility scan, this new method is a source-incompatible change, even though it has a default value:

char commentCharacter() default '#';

Could you take a look?

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc

marcphilipp · 2025-10-12T12:06:51Z

I'm a bit confused 😅 . According to the compatibility scan, this new method is a source-incompatible change, even though it has a default value

Looks like that's a false-positive reported by japicmp:

New method in annotation with default value reported as METHOD_ABSTRACT_ADDED_TO_CLASS siom79/japicmp#249

I hope that we can switch to roseau soon (see #5010) because it seems to be more precise.

For now, I just pushed a commit adding the two new attributes to the list of "accepted breaking changes" even though we know they're not actually breaking.

marcphilipp · 2025-10-12T12:07:15Z

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.1.adoc

-* ❓
+* A regression introduced in version 6.0.0 caused an exception when using the
+  `@CsvSource` or `@CsvFileSource` annotations when the `delimiter` or
+  `delimiterString` attribute was set to #. This occurred because `#` was used


Suggested change

`delimiterString` attribute was set to #. This occurred because `#` was used

`delimiterString` attribute was set to `#`. This occurred because `#` was used

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSource.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvSource.java

sbrannen · 2025-10-12T14:34:41Z

New method in annotation with default value reported as METHOD_ABSTRACT_ADDED_TO_CLASS siom79/japicmp#249

Ahhh, good that that's already been reported. 👍

I hope that we can switch to roseau soon (see #5010) because it seems to be more precise.

🤞

For now, I just pushed a commit adding the two new attributes to the list of "accepted breaking changes" even though we know they're not actually breaking.

Oh man... I literally did that at the same time as you (perhaps even before you), but I was away from the computer and came back to find you'd already pushed the same fix. 😆

Though, I sorted the entries alphabetically. 😉

sbrannen

Looking very good! 👍

I've requested a few minor changes.

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.1.adoc

gradle/config/japicmp/accepted-breaking-changes.txt

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSource.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvReaderFactory.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvSource.java

jupiter-tests/src/test/java/org/junit/jupiter/params/provider/CsvArgumentsProviderTests.java

sbrannen

"looses" -> "loses"

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSource.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvSource.java

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.1.adoc

sbrannen

Looks good. 👍

Thanks for all the work you've put into this.

vdmitrienko · 2025-10-13T21:43:46Z

Looks good. 👍

Thanks for all the work you've put into this.

My pleasure!

marcphilipp · 2025-10-14T14:38:37Z

Thank you, @vdmitrienko! 👍

The `@CsvSource` and `@CsvFileSource` annotations now allow specifying a custom comment character using the new `commentCharacter` attribute to resolve conflicts with using `#` as delimiter. Resolves #5028.

Introduce commentCharacter property in @Csv{File}Source

ff2d88d

vdmitrienko marked this pull request as draft October 6, 2025 21:38

vdmitrienko mentioned this pull request Oct 6, 2025

Can no longer use # as delimiter with @CsvSource and @CsvFileSource #5028

Closed

Apply spotless

f60b67e

vdmitrienko commented Oct 6, 2025

View reviewed changes

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvReaderFactory.java Outdated Show resolved Hide resolved

sbrannen added type: enhancement component: Jupiter theme: parameterized tests labels Oct 7, 2025

vdmitrienko added 3 commits October 11, 2025 08:48

Merge branch 'main' into 5028-introduce-comment-character

7c8e062

Skip validation of commentCharacter when CommentStrategy is NONE

76cd357

Add a note about control characters to the JavaDoc

f4b4fed

This comment was marked as outdated.

Sign in to view

vdmitrienko marked this pull request as ready for review October 11, 2025 11:29

vdmitrienko added 2 commits October 11, 2025 15:08

Document commentCharacter usage in User Guide

da91a90

Document the change in the release notes

8d6b480

osiegmar reviewed Oct 12, 2025

View reviewed changes

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc Outdated Show resolved Hide resolved

Document behavior of comments within quoted fields

dbbbb5b

vdmitrienko requested review from marcphilipp, osiegmar and sbrannen October 12, 2025 09:20

Ignore false-positives reported by japicmp

cbd7113

marcphilipp reviewed Oct 12, 2025

View reviewed changes

Polish documentation

bb6155e

sbrannen requested changes Oct 12, 2025

View reviewed changes

Fix typo: looses -> loses

10128ba

vdmitrienko added 10 commits October 12, 2025 17:26

Correct test method names

4aebe17

Remove redundant comma in exception message

60f5ba7

Apply suggestion to the Release Notes (Bug Fixes)

fc162ed

Sort accepted breaking changes alphabetically

7961662

JavaDoc: remove parentheses after method name

16875c8

JavaDoc: wrap # in single quotes

7e11bad

CsvReaderFactory: adjust formatting as suggested

76a9a1b

JavaDoc: use <em> tag instead of <i>

41ff7ef

JavaDoc: clarify rules for control characters

8a8218a

JavaDoc: wrap lines at 80 characters in CsvFileSource

82dad22

vdmitrienko requested review from marcphilipp and sbrannen October 12, 2025 17:04

osiegmar reviewed Oct 13, 2025

View reviewed changes

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc Outdated Show resolved Hide resolved

Add missing whitespace

2618c2d

marcphilipp approved these changes Oct 13, 2025

View reviewed changes

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.1.adoc Outdated Show resolved Hide resolved

Add missing indentation

013d6de

sbrannen approved these changes Oct 13, 2025

View reviewed changes

sbrannen changed the title ~~Introduce commentCharacter property in @Csv{File}Source~~ Introduce commentCharacter attribute in @Csv{File}Source Oct 13, 2025

marcphilipp linked an issue Oct 14, 2025 that may be closed by this pull request

Can no longer use # as delimiter with @CsvSource and @CsvFileSource #5028

Closed

marcphilipp merged commit 914ac2d into junit-team:main Oct 14, 2025
17 checks passed

vdmitrienko deleted the 5028-introduce-comment-character branch October 20, 2025 12:18

	`delimiterString` attribute was set to #. This occurred because `#` was used
	`delimiterString` attribute was set to `#`. This occurred because `#` was used

Uh oh!

Introduce commentCharacter attribute in @Csv{File}Source #5031

Introduce commentCharacter attribute in @Csv{File}Source #5031

Conversation

vdmitrienko commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Definition of Done

Uh oh!

Uh oh!

This comment was marked as outdated.

vdmitrienko commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vdmitrienko commented Oct 11, 2025

Uh oh!

Uh oh!

marcphilipp commented Oct 12, 2025

Uh oh!

marcphilipp Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbrannen commented Oct 12, 2025

Uh oh!

sbrannen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbrannen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbrannen left a comment

Choose a reason for hiding this comment

Uh oh!

vdmitrienko commented Oct 13, 2025

Uh oh!

Uh oh!

marcphilipp commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Introduce `commentCharacter` attribute in `@Csv{File}Source` #5031

Introduce `commentCharacter` attribute in `@Csv{File}Source` #5031

vdmitrienko commented Oct 6, 2025 •

edited

Loading

vdmitrienko commented Oct 11, 2025 •

edited

Loading