Skip to content

Conversation

@zx80
Copy link

@zx80 zx80 commented Aug 26, 2025

What kind of change does this PR introduce?

It adds to tools which are related to JSON Schema: a set of JSON Schema utils and a compiler which can export type description to JSON Schema.

Issue Number:

Closes #1831.

Screenshots/videos:

NA.

If relevant, did you update the documentation?

NA.

Summary

It adds new tools in the long list of available tools.

It is a re-submission of #1636 that I thought had been merged, but I was wrong.
I have removed the mention of the next version as it seemed to generate some concerns.

The combination of the two tools constitute a viable and rather fast JSON Schema compiler by using the schema-to-model converter of the first tool and the model compiler from the second tool.

Does this PR introduce a breaking change?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@zx80 zx80 requested a review from a team as a code owner August 26, 2025 06:53
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Aug 26, 2025
@github-actions
Copy link

Hi @zx80! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dcf4ea4) to head (40c6477).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1830   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zx80 zx80 mentioned this pull request Aug 26, 2025
1 task
@github-actions
Copy link

Hi @zx80! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@zx80
Copy link
Author

zx80 commented Aug 26, 2025

Hi @zx80! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Hello bot.

ISTM that there is an issue reference (#1831) in the PR description.

@github-actions
Copy link

Hi @zx80! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Aug 26, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 40c6477

@zx80
Copy link
Author

zx80 commented Aug 26, 2025

As I do not understand how to please the CI bots, I submitted these two entries through the issue form instead, see #1832 et #1833.

@zx80 zx80 closed this Aug 26, 2025
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Aug 26, 2025
@Relequestual
Copy link
Member

@zx80 There's some documentation on how to connect a PR to an Issue here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@zx80
Copy link
Author

zx80 commented Nov 9, 2025

@Relequestual: I closed this issue to use the form submission path instead. Should I reopen this one with keywords added to please de CI, or are the form submission sufficient and will be processed at some point in the future?

@Relequestual
Copy link
Member

@zx80 Once the GH Issue is done and agreed, you should re-open the PR or create a new one, your choice. The form is just a proxy for creating an Issue. Thanks.

@zx80 zx80 reopened this Nov 22, 2025
@github-actions
Copy link

Hi @zx80! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@zx80
Copy link
Author

zx80 commented Nov 22, 2025

@zx80 Once the GH Issue is done and agreed, you should re-open the PR or create a new one, your choice. The form is just a proxy for creating an Issue. Thanks.

Ok… It seems that the check wanted a magic word before the issue reference which was already there. The automatic message is not really helpful. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[📝 Docs]:

2 participants