-
-
Notifications
You must be signed in to change notification settings - Fork 354
Update tooling-data.yaml by adding 2 tools #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hello bot. ISTM that there is an issue reference (#1831) in the PR description. |
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
@zx80 There's some documentation on how to connect a PR to an Issue here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue |
|
@Relequestual: I closed this issue to use the form submission path instead. Should I reopen this one with keywords added to please de CI, or are the form submission sufficient and will be processed at some point in the future? |
|
@zx80 Once the GH Issue is done and agreed, you should re-open the PR or create a new one, your choice. The form is just a proxy for creating an Issue. Thanks. |
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Ok… It seems that the check wanted a magic word before the issue reference which was already there. The automatic message is not really helpful. Sigh. |
What kind of change does this PR introduce?
It adds to tools which are related to JSON Schema: a set of JSON Schema utils and a compiler which can export type description to JSON Schema.
Issue Number:
Closes #1831.
Screenshots/videos:
NA.
If relevant, did you update the documentation?
NA.
Summary
It adds new tools in the long list of available tools.
It is a re-submission of #1636 that I thought had been merged, but I was wrong.
I have removed the mention of the
nextversion as it seemed to generate some concerns.The combination of the two tools constitute a viable and rather fast JSON Schema compiler by using the schema-to-model converter of the first tool and the model compiler from the second tool.
Does this PR introduce a breaking change?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.