-
Notifications
You must be signed in to change notification settings - Fork 163
Use Fomantic layout for Images page. #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying json-ld-org with
|
| Latest commit: |
2672c58
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26aa07a3.json-ld-org.pages.dev |
| Branch Preview URL: | https://more-fomantic-pages.json-ld-org.pages.dev |
151c2de to
2672c58
Compare
| --- | ||
|
|
||
|
|
||
| # Introductory Material |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be h2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an <h2>? It's an <h1> now: https://json-ld.org/learn/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never too late to improve! I'd say it should have been h2 before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's 1000% debatable...
|
|
||
| # Introductory Material | ||
|
|
||
| - [What is Linked Data?](https://www.youtube.com/watch?v=4x_xzT5eF5Q) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the lists need the indent? Looks like the html ignores that. Easier to edit if flush left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the lists need the indent
Nope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandoc put them there. Y'all are picky. 😝
|
Thanks @davidlehn. If y'all are keen to do some cleanup, PRs welcome. |
No description provided.