Name of the main file conflicts if a module named 'http' exists#1
Open
jd20 wants to merge 3 commits intojscissr:masterfrom
Open
Name of the main file conflicts if a module named 'http' exists#1jd20 wants to merge 3 commits intojscissr:masterfrom
jd20 wants to merge 3 commits intojscissr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http-node doesn't work with projects like rn-nodeify, because rn-nodeify creates an 'http' module using the "react-native" field in package.json, which conflicts with the 'http.js' in "main" field, causing the module not to load properly. Renaming http.js => index.js fixes the issue, and doesn't seem like it would have any negative side effects.