Skip to content

Add horizontal scroll touch move support & update react deps to v17 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add horizontal scroll touch move support & update react deps to v17 #98

wants to merge 4 commits into from

Conversation

@Eugene-Musika
Copy link

@Eugene-Musika Eugene-Musika commented Aug 19, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 766a51b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@michael-alterio
Copy link

michael-alterio commented Feb 24, 2022

Came across this issue. Can we merge this? Hoping this fix resolves it.

@Eugene-Musika
Copy link
Author

Eugene-Musika commented Feb 24, 2022

Well, I've made copy of your package and using my decision as a temporary measure for a while now. So yes, it should resolve this issue

jossmac
jossmac requested changes Feb 25, 2022
View reviewed changes
src/utils.js
const target = e.currentTarget;

if (target.scrollHeight > target.clientHeight) {
if (target.scrollHeight > target.clientHeight
Copy link
Owner

@jossmac jossmac Feb 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks good 👍

Everything else should be removed from the PR

jossmac
jossmac requested changes Feb 25, 2022
View reviewed changes
Copy link
Owner

@jossmac jossmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jossmac jossmac jossmac requested changes

+1 more reviewer

@michael-alterio michael-alterio michael-alterio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eugene-Musika @michael-alterio @jossmac