Raise an error when template key cannot be found#1
Closed
h wants to merge 1 commit intojoshhansen:master_warnfrom
Closed
Raise an error when template key cannot be found#1h wants to merge 1 commit intojoshhansen:master_warnfrom
h wants to merge 1 commit intojoshhansen:master_warnfrom
Conversation
Author
|
@joshhansen Any chance you could review this PR? I submitted it over 2 years ago and would love to close it out. Thanks! |
Owner
|
Hey @h, thanks for your interest! My Best of luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit dangerous that chevron doesn't raise an error by default when a template specifies keys that don't exist in the template data. This means that unit tests will generally not catch the error when a variable is mis-typed, or forgotten entirely in the template data.
@joshhansen Issuing a warning for these errors is quite helpful, thank you! But it's not sufficient for testing templates in a unit test. The library really needs to raise an error in order to be useful in unit tests.