fix(code): refresh autocomplete when the schema changes - #1790
Open
sridharkalaibala wants to merge 1 commit into
Open
fix(code): refresh autocomplete when the schema changes#1790sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1579.
After
setSchema, validation uses the new schema but Ace keeps the autocomplete list initialized for the original schema. Assign the new schema completer to the active list as well as the option. Refresh an already-open popup, and clear/detach suggestions when schema completion is disabled so removal and re-enabling cannot retain the old values.Adds a browser regression page in
test/test_dynamic_schema.html, following the existing browser-test format. It covers initial suggestions, repeated schema replacements while the popup stays open, a single suggestion without inserting it, schema removal, and re-enabling.Validation:
developbuild at the first schema update (old suggestions persist).npm run build, all 69npm testtests,npm run lint, andgit diff --checkpass.This follows the reproduction and Ace-setter analysis shared in the issue. Prepared with AI assistance and verified against the actual editor and popup.