Skip to content

Use multiple generator threads when filtering to more than 100 log streams; fixes #82 - #84

Open
mmaslowskicc wants to merge 1 commit into
jorgebastida:masterfrom
mmaslowskicc:log-streams-limit
Open

Use multiple generator threads when filtering to more than 100 log streams; fixes #82#84
mmaslowskicc wants to merge 1 commit into
jorgebastida:masterfrom
mmaslowskicc:log-streams-limit

Conversation

@mmaslowskicc

Copy link
Copy Markdown

No description provided.

@coveralls

coveralls commented Aug 1, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 92.647% when pulling 581ef5c on mmaslowskicc:log-streams-limit into 021691b on jorgebastida:master.

@jorgebastida

Copy link
Copy Markdown
Owner

I do like this idea, but I think the code would benefit from a few changes:

  • Handle thread termination when the program has to exit.
  • Share a deque to avoid duplicated log lines between generators?

If anybody is happy to jump into updating this PR, I'll happily merge it.

@jorgebastida jorgebastida added this to the 0.12 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants