Adding command line argument to disable listing of all log streams - #319
Open
Miksu82 wants to merge 1 commit into
Open
Adding command line argument to disable listing of all log streams#319Miksu82 wants to merge 1 commit into
Miksu82 wants to merge 1 commit into
Conversation
|
@jorgebastida Please consider merging this PR, is there anything else needed to move it forward? |
|
My environment has 400K+ streams in a log group so it takes minutes to list all streams and start retrieving the events in a stream. @jorgebastida Please consider merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case where there are many many log streams, iterating through all of them takes forever which makes the
streamargument useless if exact stream name is known.This PR adds a new command line parameter to indicate that the stream parameter is exact match and
awslogsshouldn't iterate through all streams.I also considered an option where first an exact match would be tried and if found use that instead of iterating. But that would be a breaking backward compatibility so I decided to use a flag.