Skip to content

Gracefully fail when log messages are not valid json #246 - #253

Open
omriceisler wants to merge 5 commits into
jorgebastida:masterfrom
omriceisler:master
Open

Gracefully fail when log messages are not valid json #246#253
omriceisler wants to merge 5 commits into
jorgebastida:masterfrom
omriceisler:master

Conversation

@omriceisler

Copy link
Copy Markdown

Added an exception class to be used during the parsing attempt of the JSON message while building the message output.
In case the JSON is not valid or contains characters that cannot be decoded, a graceful failure will occur.

@coveralls

coveralls commented Apr 28, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.8%) to 91.246% when pulling 1eb2f36 on omriceisler:master into 401870b on jorgebastida:master.

@omriceisler

Copy link
Copy Markdown
Author

Getting:
awslogs/core.py:100:5: C901 'AWSLogs.list_logs' is too complex (30)
ERROR: InvocationError for command /home/travis/build/jorgebastida/awslogs/.tox/lint/bin/flake8 awslogs (exited with code 1)

Although, i didn't touch it.

Any suggestions ?
@jorgebastida

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants