Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Added 'set' method for android #123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added 'set' method for android #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cced751
added set method in android
saini-sahab Nov 12, 2018
9f3e3b0
fix: passing wrong props to method
saini-sahab Nov 12, 2018
849e040
fixed issues with expiration handling
saini-sahab Nov 12, 2018
8795a70
fix: get throwing errir when expiry not present
saini-sahab Nov 22, 2018
99c6640
fix: getAll throwing error when expiry not present
saini-sahab Nov 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 68 additions & 2 deletions android/src/main/java/com/psykar/cookiemanager/CookieManagerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,27 @@

import java.io.IOException;
import java.net.URISyntaxException;
import java.text.ParseException;
import java.net.URI;
import java.text.DateFormat;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Date;
import java.text.SimpleDateFormat;

public class CookieManagerModule extends ReactContextBaseJavaModule {

private static final String COOKIE_HEADER = "Cookie";
private static final String VERSION_ZERO_HEADER = "Set-cookie";

private static final String COOKIE_DOMAIN_PROPERTY = "Domain";
private static final String COOKIE_PATH_PROPERTY = "Path";
private static final String COOKIE_EXPIRES_PROPERTY = "Expires";

private static final String ISO_DATE_FORMAT_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";

private ForwardingCookieHandler cookieHandler;

public CookieManagerModule(ReactApplicationContext context) {
Expand All @@ -33,7 +46,32 @@ public String getName() {

@ReactMethod
public void set(ReadableMap cookie, boolean useWebKit, final Promise promise) throws Exception {
throw new Exception("Cannot call on android, try setFromResponse");
try {
String cookieName = this.confirmCookieProperty( "name", cookie, true );
String cookieValue = this.confirmCookieProperty( "value", cookie, true );
String cookieOrigin = this.confirmCookieProperty( "origin", cookie, true );
String cookieDomain = this.confirmCookieProperty( "domain", cookie, false );
String cookiePath = this.confirmCookieProperty( "path", cookie, false );
String cookieVersion = this.confirmCookieProperty( "version", cookie, false );
String cookieExpiration = this.confirmCookieProperty( "expiration", cookie, false );

String cookieString = cookieName + '=' + cookieValue + ';';

if( !cookieDomain.isEmpty() ) {
cookieString += ' ' + COOKIE_DOMAIN_PROPERTY + '=' + cookieDomain + ';';
}
if( !cookiePath.isEmpty() ) {
cookieString += ' ' + COOKIE_PATH_PROPERTY + '=' + cookiePath + ';';
}
if( !cookieExpiration.isEmpty() ) {
cookieString += ' ' + COOKIE_EXPIRES_PROPERTY + '=' + this.convertToUTC( cookieExpiration ) + ';';
}

this.setCookie( cookieOrigin, cookieString );
promise.resolve( true );
} catch( Exception e ) {
promise.reject(e);
}
}

@ReactMethod
Expand Down Expand Up @@ -73,7 +111,7 @@ public void get(String url, boolean useWebKit, Promise promise) throws URISyntax
for (int i = 0; i < cookies.length; i++) {
String[] cookie = cookies[i].split("=", 2);
if (cookie.length > 1) {
map.putString(cookie[0].trim(), cookie[1]);
map.putString(cookie[0].trim(), cookie[1]);
}
}
}
Expand All @@ -88,4 +126,32 @@ public void invoke(Object... args) {
}
});
}

private void setCookie( String url, String value ) throws URISyntaxException, IOException {
URI uri = new URI(url);
Map<String, List<String>> cookieMap = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map cookieMap = new HashMap<String, List<String>>(); is better looks like than that.

cookieMap.put( VERSION_ZERO_HEADER, Collections.singletonList(value) );
this.cookieHandler.put( uri, cookieMap );
}

private String confirmCookieProperty( String propName, ReadableMap cookieObj, Boolean isNecessary ) throws Exception {
String propValue = cookieObj.hasKey( propName ) ? cookieObj.getString( propName ) : "";

if( propValue != null && !propValue.isEmpty() ) {
return propValue;
} else {
if( isNecessary ) {
throw new Exception( propName + " property of cookie obj must have a value" );
} else {
return "";
}
}
}

private String convertToUTC(String timestamp) throws ParseException, Exception {
SimpleDateFormat parser = new SimpleDateFormat( ISO_DATE_FORMAT_PATTERN );
Date parsedDate = parser.parse(timestamp);
SimpleDateFormat utcFormatter = new SimpleDateFormat( "E, dd MMM YYYY HH:mm:ss" );
return utcFormatter.format(parsedDate) + " GMT";
}
}
12 changes: 10 additions & 2 deletions ios/RNCookieManagerIOS/RNCookieManagerIOS.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,11 @@ -(NSString *)getDomainName:(NSURL *) url
[d setObject:c.name forKey:@"name"];
[d setObject:c.domain forKey:@"domain"];
[d setObject:c.path forKey:@"path"];
[d setObject:[self.formatter stringFromDate:c.expiresDate] forKey:@"expiresDate"];
if( c.expiresDate == nil || c.expiresDate == (id)[NSNull null] ) {
[d setObject:@"" forKey:@"expiresDate"];
} else {
[d setObject:[self.formatter stringFromDate:c.expiresDate] forKey:@"expiresDate"];
}
[cookies setObject:d forKey:c.name];
}
resolve(cookies);
Expand Down Expand Up @@ -240,7 +244,11 @@ -(NSString *)getDomainName:(NSURL *) url
[d setObject:c.name forKey:@"name"];
[d setObject:c.domain forKey:@"domain"];
[d setObject:c.path forKey:@"path"];
[d setObject:[self.formatter stringFromDate:c.expiresDate] forKey:@"expiresDate"];
if( c.expiresDate == nil || c.expiresDate == (id)[NSNull null] ) {
[d setObject:@"" forKey:@"expiresDate"];
} else {
[d setObject:[self.formatter stringFromDate:c.expiresDate] forKey:@"expiresDate"];
}
[cookies setObject:d forKey:c.name];
}
}
Expand Down