Skip to content

fix: fixes casing of version strings #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: fixes casing of version strings #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
use color_eyre::eyre::{eyre, Context, ContextCompat, Result};
use convert_case::{Case, Casing};
use regex::Regex;
use std::path::Path;
use std::sync::LazyLock;

use crate::parsing::{find_suite, find_test, get_group_comment, get_groups, get_suite_chunk};
use crate::runner::Runner;
use crate::target::Target;
use crate::ConfigMeta;
use crate::{document::Document, group::Group, suite::Suite, test::Test};

// Regex to fix version patterns like v_1, V_2 back to v1, V2
// This is needed because convert_case treats letter-to-number transitions as word boundaries
static VERSION_PATTERN: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"([vV])_(\d+)").unwrap());

fn case_from_str(s: &str) -> Result<Case> {
match s {
"Alternating" => Ok(Case::Alternating),
Expand Down Expand Up @@ -36,9 +42,11 @@ fn case_from_str(s: &str) -> Result<Case> {
}

fn convert_case_filter(input: &str, case: &str) -> String {
input.to_case(case_from_str(case).unwrap_or_else(|e| {
let result = input.to_case(case_from_str(case).unwrap_or_else(|e| {
panic!("failed to convert case: {}", e);
}))
}));
// Fix version patterns like v_1, V_2 back to v1, V2 (preserving case)
VERSION_PATTERN.replace_all(&result, "$1$2").to_string()
}

pub fn insert_after_keyword(original: &str, to_insert: &str, keyword: &str) -> String {
Expand Down