Implement support for XYZ mesh input #43

sabakhshi · 2025-10-27T21:04:11Z

WIP implementation of XYZ mesh format as geometry input bypassing AVL's geometry.
Will include support for arbitrary point clouds, pyGeo (VSP, ESP, and FFD), and OpenAeroStruct Geometry via OpenMDAO.

Originally: Add the ability to output the mesh in XYZ format to the OVLMeshReader component. This makes running postprocessing scripts intended for OpenAeroStruct easier. Let me know if this output would be better in another component. I plan to add a lot more to this so it's a draft for now.

… fixed scale and translate of custom meshes not working

…ng in common block

joanibal

Good stuff. See my comment

joanibal · 2025-11-03T19:41:18Z

src/amake.f

+      end if
+
+      ! Unlike the standard fudging routine we have no idea where 
+      ! each section's leading edge is located ahead of time


Do you mean outer edge here?

Subroutine removed in latest version.

joanibal · 2025-11-03T19:43:52Z

src/amake.f

+      ! The prior routine only considers the y distance while
+      ! Drela considers y and z. However, the above routine appears 
+      ! to work fine on its own and running this after appears to
+      ! cause issues.


What kind of issues? It would be ideal if the fudging routines were as close as practical.

Subroutine removed in latest version. Sections no longer relevant to mesh setting.

joanibal · 2025-11-03T19:46:25Z

src/amake.f

+     &      ' does not match NSEC(isurf):', NSEC(isurf)
+      endif
+
+      ! If the user doesn't input a index vector telling us at what 


nitpick, but please do not use contractions in comments as it can mess up the syntax highlighting (like on github).

Code section removed from subroutine in latest version but I'll keep this in mind going forward

joanibal · 2025-11-03T19:47:52Z

src/amake.f

+      ! Set spanwise elements to 0
+      NJ(ISURF) = 0
+
+      ! Check control and design vars (input routine should've already checked this tbh)


Contraction in comment, see above

joanibal · 2025-11-03T19:50:20Z

src/amake.f

+
+
+      ! We need to compute the chord and claf values at the left and right edge of the section
+      ! These will be needed by AVL for control surface setup and control point placement 


But doesn't avl assume a linear variation in the chord? If so wouldn't we have to do the control surface setup differently for custom meshes?

We now interpolate over individual strips as the strip boundaries hence all the linear interpolations should now be valid. The control setup and configuration has been reworked entirely to allow assignment of controls and design vars to strip individually.

joanibal · 2025-11-03T19:59:28Z

src/amake.f

+      do ispan = 1,nspan
+      idx_y = idx_strip - JFRST(isurf) + 1


Can you indent loops

I've found myself running into the 70 character limit so many times with this that I'm afraid that the lines will become totally unreadable if indented any more.

joanibal · 2025-11-03T20:11:53Z

src/amake.f

+!       m1 = ((mesh(1,nx,idx_y+1)+mesh(1,nx,idx_y))/2) - 
+!      & ((mesh(1,1,idx_y+1)+mesh(1,1,idx_y))/2)
+!       m3 = ((mesh(3,nx,idx_y+1)+mesh(3,nx,idx_y))/2) - 
+!      & ((mesh(3,1,idx_y+1)+mesh(3,1,idx_y))/2)
+!       CHORD(idx_strip) = sqrt(m1**2 + m3**2)


remove commented code?

I've removed most instances of commented code with a few exceptions so people can follow along with the rational as to why something was changed from the original AVL routine. We can deleted them if you would like.

joanibal · 2025-11-03T20:15:36Z

src/amake.f

+      ENDDO
+
+      ! We have to now setup any control surfaces we defined for this section
+      ! Bring over the routine for this from Drela


See comment above about "from Drela". It would probably be more informative to say "from makesurf"

joanibal · 2025-11-03T20:19:53Z

src/amake.f

+       ! Left bound vortex points 
+       ! Y- point
+       RV1(2,idx_vor) = mesh(2,idx_x,idx_y)  
+       ! Compute the panel's left side chord and angle


contraction in comment (see above)

joanibal · 2025-11-03T20:20:01Z

src/amake.f

+       ! Mid-point bound vortex points 
+       ! Y- point
+       RV(2,idx_vor) = (mesh(2,idx_x,idx_y+1) + mesh(2,idx_x,idx_y))/2.
+       ! Compute the panel's mid-point chord and angle


contraction in comment (see above)

…fortran layer indexing bugs. runtime mesh updating still needs to be implemented

sabakhshi and others added 13 commits October 15, 2025 16:55

Add mesh output to OM reader

23624f5

Initial commit of direct mesh setting

3b99ca4

Implemented python interface and setting basic meshes works

bd25ced

minor fixes for adjust_mesh_spacing

4462a65

Fixes for the automatic section slicing routines

85135d3

Fixes for using nspans to define sections

26820d2

Fix direct spec of iploc and fix numerous issues with controls

83512c4

tweak f2py interface to pass size explicitly

b443660

Fix broken ainc interp and fix broken camber slope interp

419d72e

Fixed multiple surfaces not being handled correct with custom meshes.…

ca41ba4

… fixed scale and translate of custom meshes not working

fix tecplot file writing

dc03dec

start figuring out an update routine

3728fd3

hacked in a way to update surfaces without store or allocating anythi…

10ac86b

…ng in common block

joanibal requested changes Nov 3, 2025

View reviewed changes

sabakhshi added 16 commits November 3, 2025 19:21

WIP rework

455fe81

Wip stuff

27d8289

Wip

0514f65

Finally finished the flat index rework for direct mesh

488a312

Implement flat mesh setting in python layer initialization. fix some …

b283efc

…fortran layer indexing bugs. runtime mesh updating still needs to be implemented

Implement new normal calcs for custom meshes

0967bce

Implemented mesh flattening

4c5e34b

start cleaning up for PR

e264a5f

integrated encalc routine for custom meshes into the main one

cc67879

Added plotting features

426e43f

New control definition implemention. section free

3637270

removing section loop from amake.wip

469a667

Complete rework of fortran subroutines for custom meshes

8aa02da

Reworked Mesh implementation. Ready for initial review

b7b5020

Remove contractions from fortran comments

48da6af

merge AVL 3.52 into branch

5c360f3

sabakhshi added 5 commits February 3, 2026 01:54

Manually clean up some things to complete the merge

14d1afd

Cleaned up some utility functions in the python class

5672f7e

Some things missed from last commit

889b00d

fix naca specification for meshes

9f384d2

Fix tecplot writing from input dict for now

0578fb4



		! We need to compute the chord and claf values at the left and right edge of the section
		! These will be needed by AVL for control surface setup and control point placement

Implement support for XYZ mesh input #43

Are you sure you want to change the base?

Implement support for XYZ mesh input #43

Uh oh!

Conversation

sabakhshi commented Oct 27, 2025

Uh oh!

joanibal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants