Modernize for 2025 (Python 3.9+ only)#8
Open
dlenski wants to merge 13 commits into
Open
Conversation
dlenski
changed the title
And also un-confuse mypy type checker for `Optional[int]` case
…d packet A simple test case for this revealed that `parse_into()` was broken and couldn't actually parse a buffer containing multiple concatenated packets, even though that seems to have been the entire reason for its progressive-parsing structure. 🤔 So I fixed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for
six,attrs(replace withdataclasses), externaltyping,binascii.unhexlify, etc.I also renamed the
parse(msg: bytes, output: list) -> intmethod toparse_into, and created a more convenientparse(msg: bytes) -> tuple(int, list)method that returns a newly-createdlistof parsed messages.Testing
toxpassing for Python 3.9, 3.10, 3.11, 3.12, and mypy