Skip to content

fixing a tiny typo #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixing a tiny typo #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ AssertionFailedError: Property [BST Properties:union valid]
right: NIL]
```

> Thus, at first sight, there is nothing to indicate that the bug is in `insert`; all of `insert`, `delete` and `union` can return invalid trees! However, `delete` and `unin` are given invalid trees as inputs in the tests above, and we cannot expect them to return valid trees in this case, so these reported failures are “false positives”.
> Thus, at first sight, there is nothing to indicate that the bug is in `insert`; all of `insert`, `delete` and `union` can return invalid trees! However, `delete` and `union` are given invalid trees as inputs in the tests above, and we cannot expect them to return valid trees in this case, so these reported failures are “false positives”.
>
> The problem here is that the generator for trees is producing invalid ones (because it is defined in terms of `insert`). We could add a precondition to each property, requiring the tree to be valid, as in:

Expand Down