-
Notifications
You must be signed in to change notification settings - Fork 39
Fix macOS NuGet tests - prioritize .NET MSBuild over Mono MSBuild #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eyalk007
wants to merge
3
commits into
jfrog:main
Choose a base branch
from
eyalk007:fix-macos-nuget-msbuild-priority
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a0d06e to
5ec8b8a
Compare
5ec8b8a to
9c98cfe
Compare
9c98cfe to
6c778d1
Compare
6c778d1 to
46afd12
Compare
46afd12 to
4d82dc6
Compare
4d82dc6 to
8650cb8
Compare
Install Mono 5.2.0 which has better MSBuild compatibility with .NET Core projects, resolving the 'Too many project files specified' error. Mono 5.2 was tested locally and eliminates MSBuild conflicts that occur with newer Mono versions (6.x) on macOS. Fixes: TestSkipBuildDepTreeWhenInstallForbidden failures on macOS CI
8650cb8 to
fbc65ea
Compare
Use modern Mono 6.x with MSBuild environment variables pointing to .NET SDK instead of downgrading to Mono 5.2. This approach was tested locally and eliminates MSBuild conflicts while maintaining compatibility. Changes: - Install modern Mono 6.x (fast, no large downloads) - Set MSBUILD_EXE_PATH to .NET SDK MSBuild.dll - Set MSBuildSDKsPath to .NET SDK Sdks directory - Upgrade to setup-dotnet@v5 This allows NuGet.exe to use Mono runtime while dotnet restore uses .NET MSBuild. Tested locally - eliminates 'Too many project files specified' errors.
acab218 to
c35c532
Compare
Tested locally: dotnet restore works perfectly with .NET 7 + modern NuGet 6.14 + Mono 6.14. The MSBuild environment variable approach resolves tool conflicts. Changes: - Install modern Mono 6.x (with Homebrew caching) - Set MSBUILD_EXE_PATH and MSBuildSDKsPath to .NET SDK - Upgrade to setup-dotnet@v5 - Add fast NuGet unit test job for quick feedback Local testing confirms MSBuild compatibility is resolved.
c35c532 to
ba14026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore for release
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Resolves TestSkipBuildDepTreeWhenInstallForbidden failures on macOS CI where Mono's deprecated MSBuild was taking precedence over .NET's MSBuild.
The issue occurred because:
Fix adds .NET paths to front of PATH after Mono installation to ensure .NET's MSBuild is used for NuGet/dotnet operations.
Fixes: MSBUILD error MSBUILD0004: Too many project files specified