Skip to content

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Aug 26, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

Static-SCA Improvements:

  1. Automatic cdx upload of audit/git audit scan results (you can control which repo by --upload-rt-repo-path),
    A note is added with a link to the scan results that were uploaded.
  2. Wait, fetch, and parse Xray violations using the new API call (generated by JPD for the cdx artifact)
  3. upload-cdx: Wait for results to be parsed by Xray before showing the link.

Other Improvements:

  1. Add --sbom option to git-audit cmd
  2. INFO level Log, extra msg text. and links Improvements & Fixes. (add durations to scans)
  3. Little code refactors to remove code duplications
  4. Align BOM REF to reflect REF in Xray (pkg:/file: prefix, / as delimiter)
  5. Add fail build attribute to simple-json format.
  6. Refactor convertors interface (remove redundant target input for each method)
  7. dump final cdx format file to out-dir if requested
  8. SARIF format - violations will now be displayed at a different run

attiasas added 30 commits July 17, 2025 13:30
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 19, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 20, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2025
@attiasas attiasas marked this pull request as ready for review November 20, 2025 09:00
}

func TestAuditNewScaCycloneDxYarn(t *testing.T) {
// TODO: yarn not working....
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder

@jfrog jfrog deleted a comment from github-actions bot Nov 23, 2025
@jfrog jfrog deleted a comment from github-actions bot Nov 23, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 23, 2025
@attiasas attiasas merged commit bdfcc88 into jfrog:dev Nov 23, 2025
61 of 62 checks passed
@attiasas attiasas deleted the static_sca_violations_remediations branch November 23, 2025 15:03
basel1322 pushed a commit to basel1322/jfrog-cli-security that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants