Job to aggregate can contain variable, expand it before use#72
Open
ahahxof wants to merge 4 commits into
Open
Conversation
ahahxof
commented
Jun 9, 2017
| import static hudson.Util.fixNull; | ||
| import hudson.model.Action; | ||
| import hudson.model.BuildListener; | ||
| import hudson.model.DependencyGraph; |
Author
There was a problem hiding this comment.
I don't need this, sorry. I will remove it and the excess new lines added below
abayer
requested changes
Nov 9, 2017
Member
abayer
left a comment
abayer
left a comment
There was a problem hiding this comment.
Please add a unit test for this change. Thanks!
Author
|
@abayer I've added the test. please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems no existing Unit tests in the project uses env variable so I skip this part. let me know if you want me to add one.