Conversation
Bumps [database](https://github.com/jenkinsci/database-plugin) from 117.va2009e38b882 to 128.vaa83e142f7f2. - [Release notes](https://github.com/jenkinsci/database-plugin/releases) - [Commits](https://github.com/jenkinsci/database-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:database dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # pom.xml
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # pom.xml
uhafner
commented
Feb 21, 2022
|
|
||
| JUnitBuildSummary buildSummary = new JUnitBuildSummary(build); | ||
|
|
||
| assertThat(buildSummary.getTitleText()).containsAnyOf("no failures", "0 failures"); |
Member
Author
There was a problem hiding this comment.
It would make sense to split the title into the link and the text in the brackets and check both of them
| JUnitBuildSummary buildSummary = new JUnitBuildSummary(build); | ||
|
|
||
| assertThat(buildSummary.getTitleText()).containsAnyOf("no failures", "0 failures"); | ||
| assertThat(buildSummary.getFailureNames()).isEmpty(); |
Member
Author
There was a problem hiding this comment.
Use the generated assertions:
Suggested change
| assertThat(buildSummary.getFailureNames()).isEmpty(); | |
| assertThat(buildSummary).hasNoFailureNames(); |
| assertThat(buildSummary.getFailureNames()) | ||
| .containsExactlyInAnyOrder("JUnit.testScore[0]", "JUnit.testScore[1]", "JUnit.testScore[2]", "TestNG.testScore", "TestNG.testScore", "TestNG.testScore"); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Since the build summary supports navigation using links, it would be helpful to check these as well (and navigate to the detail pages)
Comment on lines
+40
to
+44
| assertThat(buildTestResultsByClass.getTestTableEntries()).extracting(List::size).isEqualTo(2); | ||
|
|
||
| TestUtils.assertElementInCollection(buildTestResultsByClass.getTestTableEntries(), | ||
| testTableEntry -> testTableEntry.getTestName().equals("testAppFailNoMessage"), | ||
| testTableEntry -> testTableEntry.getTestName().equals("testAppFailNoStacktrace")); |
Member
Author
There was a problem hiding this comment.
AssertJ is your friend, make usage of the API:
assertThat(buildTestResultsByClass.getTestTableEntries())
.hasSize(2)
.extracting(TestTableEntry::getTestName)
.containsExactly("testAppFailNoMessage", "testAppFailNoStacktrace");
Seems that your import is wrong (in all tests!), you need to import
import static io.jenkins.plugins.analysis.junit.Assertions.*;
| .openTestResultsByClass("ApplicationTest"); | ||
|
|
||
| TestUtils.assertElementInCollection(buildTestResultsByClass.getTestTableEntries(), | ||
| tableEntry -> tableEntry.getTestName().equals("testAppFail") && tableEntry.getStatus().equals("Failed"), |
| * @param predicates assertion criteria | ||
| * @param <E> the type of elements in this collection | ||
| */ | ||
| public static <E> void assertElementInCollection(Collection<E> collection, |
Member
Author
There was a problem hiding this comment.
Should work out of the box with standard AssertJ
| */ | ||
| public class BuildChartEntry { | ||
|
|
||
| final int buildId; |
Comment on lines
+56
to
+58
| WebElement mainPanel = getElement(By.cssSelector("#main-panel")); | ||
| packageLinks = TestResultsTableUtil.getLinksOfTableItems(mainPanel); | ||
| packageTableEntries = initializePackageTableEntries(mainPanel); |
Member
Author
There was a problem hiding this comment.
Extract duplicate code into method
Comment on lines
+57
to
+59
| WebElement mainPanel = getElement(By.cssSelector("#main-panel")); | ||
| testLinks = TestResultsTableUtil.getLinksOfTableItems(mainPanel); | ||
| testTableEntries = initializeTestTableEntries(mainPanel); |
Member
Author
There was a problem hiding this comment.
Extract duplicate code into method
Comment on lines
+57
to
+59
| WebElement mainPanel = getElement(By.cssSelector("#main-panel")); | ||
| classLinks = TestResultsTableUtil.getLinksOfTableItems(mainPanel); | ||
| classTableEntries = initializeClassTableEntries(mainPanel); |
Member
Author
There was a problem hiding this comment.
Extract duplicate code into method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #342.
The first two commits have been moved to a separate branch so that GitHub UI will not freeze during reviews anymore.