Use truncated strings from checks api#236
Open
mrginglymus wants to merge 2 commits into
Open
Conversation
timja
approved these changes
Jan 10, 2021
Member
timja
left a comment
timja
left a comment
There was a problem hiding this comment.
looks sane, I wrote a test for this initially but I couldn't manage to make windows CI pass and I think I ended up deleting the test
timja
approved these changes
Jan 30, 2021
Member
Short of putting it in the release notes, no |
timja
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer implementation of jenkinsci/checks-api-plugin#68
Is there a way we can set a constraint on the version of
github-checks-pluginwithout requiring it to be installed, such that we don't have to go through a gradual deprecation process of the old logic?