Support docking the sidebar via Alpine teleport - #30
Closed
jeffreyvr wants to merge 4 commits into
Closed
Conversation
Hosts can pass sidebarTeleport with a CSS selector so the sidebar renders outside the canvas column while staying on the same Alpine root.
Alpine x-teleport only moves one root; the backdrop and sidebar were siblings, so only the backdrop docked and init crashed on a missing blocks inserter ref.
Alpine runs init before x-teleport, so docked sidebar refs were missing and Sortable never attached. Set up the inserter on the next tick.
Deferring Alpine on the parent for sidebar teleport also set paver()->alpine false, which the frame read and never booted. Edit actions then did nothing. The frame is a separate document and must always start its own bundle.
Owner
Author
|
Closing: docked WP sidebar worked technically but the responsive/UX tradeoff was not worth it. Sticking with the in-editor rail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sidebarTeleportconfig (CSS selector) so hosts can dock the sidebar outside the canvas columnx-teleportkeeps the same Paver root for options, inserter, and history.paver__dockedstyles for full-width canvas when the rail is externalUsed by paver-for-wordpress to put blocks/options in the WP side meta box.
Test plan