Skip to content

Add toReference to fieldPolicies #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add toReference to fieldPolicies #113

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad1433
Add toReference to fieldPolicies
jfrolich Jun 3, 2021
584f72f
Do not depend on record
jfrolich Jun 3, 2021
afbb0d3
Fix bug
jfrolich Jun 4, 2021
ab32aea
Wrong order
jfrolich Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/@apollo/client/cache/inmemory/ApolloClient__Cache_InMemory_Policies_FieldPolicy.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ module StorageType = {

module FieldFunctionOptions = {
type unimplemented

type reference = {__typename: string, id: string}

module Js_ = {
// export interface FieldFunctionOptions<TArgs = Record<string, any>, TVars = Record<string, any>> {
// args: TArgs | null;
Expand Down Expand Up @@ -55,7 +56,7 @@ module FieldFunctionOptions = {
"canRead"
@bs.send external readField: t => ReadFieldFunction.Js_.t = "readField"
@bs.send
external toReference: t => ToReferenceFunction.t = "toReference"
external toReference: (t, reference) => string = "toReference"
}

type t = {
Expand All @@ -65,7 +66,7 @@ module FieldFunctionOptions = {
field: Js.nullable<FieldNode.t>,
variables: option<Js.Dict.t<Js.Json.t>>,
isReference: bool,
toReference: unimplemented,
toReference: (~id: string, ~typename: string,) => string,
storage: Js.nullable<StorageType.t>,
cache: ApolloCache.t<Js.Json.t>,
readField: unimplemented,
Expand All @@ -80,7 +81,9 @@ module FieldFunctionOptions = {
field: js.field,
variables: js.variables,
isReference: js.isReference,
toReference: js.toReference,
toReference: (~id, ~typename) => {
js->Js_.toReference({id: id, __typename: typename})
},
storage: js.storage,
cache: js.cache,
readField: js.readField,
Expand Down