Change settings panel behavior to slide instead of grow#110
Open
UnSeulT wants to merge 2 commits intojech:masterfrom
Open
Change settings panel behavior to slide instead of grow#110UnSeulT wants to merge 2 commits intojech:masterfrom
UnSeulT wants to merge 2 commits intojech:masterfrom
Conversation
…fix the weird render during transition.
Owner
|
I'm confused. Was that not fixed by 7aefb5e? |
Contributor
Author
|
It was in a way :) |
|
I have tested the merge request on top of current 0.7.1 and can attest that opening and closing the settings sidebar works nicely on Firefox. Plus it is 11 lines of code less, so +1 for merging :) |
65fa0be to
03038ea
Compare
b7172df to
8de77fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the animation issue mentioned by @MisterDA in #109