Open
Conversation
To display in various languages
Adapted from https://github.com/andreasremdt/simple-translator per Andreas Remdt <me@andreasremdt.com> (https://andreasremdt.com)
Open
Owner
|
Please include the licensing information for simple-translator. Perhaps it should go into its own subdirectory of scripts/? Where's the part that internationalises messages that come from Javascript? |
Author
|
Hello, it's not finished yet. |
Owner
Ah, ok. Please remove « WIP » from the subject when you feel it's ready to review.
A number of messages are generated by the Javascript code. Look at the calls to « displayError », for example. |
65fa0be to
03038ea
Compare
b7172df to
8de77fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for the index.html page but the bases are here for i18n
The same logic has to be done with galene.html and 404.html