ADO reports / use proper sql escape function according to database vendor#163
Open
tnguyen1 wants to merge 1 commit intojdorn:masterfrom
Open
ADO reports / use proper sql escape function according to database vendor#163tnguyen1 wants to merge 1 commit intojdorn:masterfrom
tnguyen1 wants to merge 1 commit intojdorn:masterfrom
Conversation
…ndor - was always using mysql_real_escape_string function which made macros values empty with postgres - current behaviour: if dsn uri starts with 'postgres' then use pg_escape_string function - use mysql_real_escape_string function otherwise
|
+1. I lost a lot of time until I found this solution ... Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysql_real_escape_stringfunction which made macro values empty for other databases like postgresqlThere must be a better way to fix it though but the idea is to be able to use any database vendor (not only MySQL) with ADO connections.