Draft
Conversation
# Conflicts: # scripts/pmd7_rules_xml_generator.groovy # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/PmdTemplate.java
# Conflicts: # scripts/pmd7_rules_xml_generator.groovy
# Conflicts: # pom.xml # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/AbstractPmdExecutor.java # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/PmdPlugin.java # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/PmdSensor.java # sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdPluginTest.java # sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdSensorTest.java
|
# Conflicts: # integration-test/pom.xml # integration-test/src/test/java/com/sonar/it/java/suite/PmdIT.java # integration-test/src/test/java/com/sonar/it/java/suite/PmdKotlinIT.java # integration-test/src/test/java/com/sonar/it/java/suite/TestUtils.java # integration-test/src/test/java/com/sonar/it/java/suite/orchestrator/PmdTestOrchestrator.java # pom.xml # scripts/pmd7_rules_xml_generator.groovy # sonar-pmd-plugin/pom.xml # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/PmdConstants.java # sonar-pmd-plugin/src/main/java/org/sonar/plugins/pmd/PmdPlugin.java
# Conflicts: # integration-test/src/test/java/com/sonar/it/java/suite/PmdIT.java
Open
# Conflicts: # sonar-pmd-lib/src/main/java/org/sonar/plugins/pmd/PmdConstants.java # sonar-pmd-lib/src/main/java/org/sonar/plugins/pmd/xml/PmdRuleSet.java # sonar-pmd-plugin/src/main/resources/org/sonar/plugins/pmd/rules-java.xml # sonar-pmd-plugin/src/main/resources/org/sonar/plugins/pmd/rules-kotlin.xml
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of the
master-activate-kotlin-sensorbranch and is work-in-progress.This solves #361
This is a working version with Apex PMD rules. You can try it out if you download the zip file of the PR build.
There is unfinished work:
Found out there is also a Sonar Apex plugin, so that will probably define a Sonar way and also the Apex language. E.g. see apex:AS3923 violation on our integration test.
Sonar Apex rules are part of the Enterprise Edition, so not all users will have the parent Apex Sonar plugin. How to deal with language and initial Apex profile? Can be done conditional?
We can now add
teststag for test only. Which Apex rules apply? Can maybe be mapped automatically based on message?It is still bigger that Java/Kotlin, but maybe Apex just needs more jars. It is now 41MB.