Fix base64 routing regex and XSS vulnerabilities in templates#44
Fix base64 routing regex and XSS vulnerabilities in templates#44jbalagiya wants to merge 1 commit into
Conversation
…dated regex for `/c/` and `/w/` routes to use `(.+)` to properly capture base64-encoded strings containing slashes.\n- Created `escapeForScript` helper to sanitize inputs injected into templates.\n- Replaced direct string replacements with callback functions in `renderTemplate` to prevent `$&` special string replacement bugs and XSS vulnerabilities. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This commit addresses two critical bugs in the codebase:
/c/and/w/used regex that broke if base64 encoded strings contained slashes.renderTemplatefunction used standard.replacecombined with raw data strings making it vulnerable to XSS and special string replacement bugs. It now uses a helper and callback to avoid it.PR created automatically by Jules for task 10973357546395819194 started by @jbalagiya