Fix template rendering safety and base64 URL routing#42
Conversation
- Implement \`escapeForScript\` to safely escape input when injected into JavaScript string contexts within HTML templates. - Update \`renderTemplate\` to use a callback function for replacement to prevent regex special character interpretation bugs (like \`$&\`). - Fix regex matchers for \`/c/\` and \`/w/\` endpoints to use \`(.+)\` instead of \`([^/]+)\` for capturing the target URL, since base64 encoded strings might contain slashes. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This commit addresses several common bugs in string rendering and URL routing:
PR created automatically by Jules for task 6649818634429550193 started by @jbalagiya