Fix routing and template rendering bugs#40
Conversation
- Updated `path.match` for `/c/` and `/w/` routes to use `(.+)` to handle base64 urls containing slashes. - Add `escapeForScript` helper to sanitize string values passed into html templates. - Update `renderTemplate` replacement logic to use the callback form, avoiding string replacement injection bugs and preventing XSS. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes two key issues in the
worker.jsapplication:([^/]+)). Updating the regex to use(.+)correctly handles these encoded URL strings.escapeForScripthelper to sanitize values passed to the HTML templates, and updated the.replacelogic to use a callback function (() => uid) instead of a direct string. This is to avoid the injection of special replacement strings like$&and completely mitigate XSS vulnerabilities.PR created automatically by Jules for task 18322213029604634943 started by @jbalagiya