fix(worker): Regex handling and templating security enhancements#37
fix(worker): Regex handling and templating security enhancements#37jbalagiya wants to merge 1 commit into
Conversation
- Updated regex in `cloudflareMatch` and `webviewMatch` to use `(.+)` to capture URIs with base64 slashes. - Implemented `escapeForScript` helper to sanitize data for template injection. - Updated `renderTemplate` replacement logic to use the callback pattern to prevent special replacement tokens (`$&`) and XSS vulnerabilities. Co-authored-by: jbalagiya <143921503+jbalagiya@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
cloudflareMatchandwebviewMatchendpoints to correctly accommodate paths containing base64 encoded strings, which can contain slashes, utilizing(.+)rather than([^/]+).escapeForScripthelper function to safely process template arguments, minimizing risk of XSS vulnerabilities.renderTemplatelogic to use the replacement callback mechanism rather than plain strings in order to prevent errors with string variables containing replacement strings like$&.PR created automatically by Jules for task 4760519959947458070 started by @jbalagiya